-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to new egg-bin #63
Conversation
@@ -2,12 +2,13 @@ | |||
"files.exclude": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 这个文件可以干掉?
- 另外,只注释 when 没用的,要把
**/*.js
也注释才生效,否则是全隐藏
}, | ||
"**/*.map": true, | ||
"run": true, | ||
"logs": true, | ||
"out": true, | ||
"node_modules": true | ||
} | ||
}, | ||
"typescript.tsdk": "node_modules/typescript/lib" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个用处是? 是不是可以直接加到 tsconfig.json 的?
hackernews-async-ts/.eslintrc
Outdated
@@ -0,0 +1,7 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个干掉, eslint 也干掉,先保持 tslint 吧
import * as fs from 'fs'; | ||
import * as path from 'path'; | ||
|
||
export default (appInfo: EggAppConfig) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EggAppInfo 的那个改改,这里不对
}, | ||
}, | ||
news: { | ||
pageSize: 30, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这几个地方都加注释的话,是否能 IDE 提示?
hackernews-async-ts/package.json
Outdated
"egg-bin": "^4.6.0", | ||
"egg-mock": "^3.16.0", | ||
"egg-ts-helper": "^1.1.3", | ||
"eslint": "^4.19.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint 干掉
hackernews-async-ts/package.json
Outdated
"tslib": "^1.8.1", | ||
"tslint": "^4.0.0", | ||
"typescript": "^2.6.2", | ||
"typescript-eslint-parser": "^14.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
干掉
hackernews-async-ts/package.json
Outdated
"start": "egg-scripts start", | ||
"dev": "egg-bin dev -r 'egg-ts-helper/register'", | ||
"tsc": "ets && tsc -p tsconfig.json", | ||
"clean": "rimraf ./app.js ./agent.js ./{app,test,config}/**/*.{js,map}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
换为 ets clean
Checklist
npm test
passesAffected core subsystem(s)
Description of change