Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to new egg-bin #63

Merged
merged 11 commits into from
Apr 2, 2018
Merged

feat: update to new egg-bin #63

merged 11 commits into from
Apr 2, 2018

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Mar 29, 2018

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@atian25 atian25 requested a review from shepherdwind April 1, 2018 06:33
@@ -2,12 +2,13 @@
"files.exclude": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 这个文件可以干掉?
  • 另外,只注释 when 没用的,要把 **/*.js 也注释才生效,否则是全隐藏

},
"**/*.map": true,
"run": true,
"logs": true,
"out": true,
"node_modules": true
}
},
"typescript.tsdk": "node_modules/typescript/lib"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个用处是? 是不是可以直接加到 tsconfig.json 的?

@@ -0,0 +1,7 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个干掉, eslint 也干掉,先保持 tslint 吧

import * as fs from 'fs';
import * as path from 'path';

export default (appInfo: EggAppConfig) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EggAppInfo 的那个改改,这里不对

},
},
news: {
pageSize: 30,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这几个地方都加注释的话,是否能 IDE 提示?

"egg-bin": "^4.6.0",
"egg-mock": "^3.16.0",
"egg-ts-helper": "^1.1.3",
"eslint": "^4.19.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint 干掉

"tslib": "^1.8.1",
"tslint": "^4.0.0",
"typescript": "^2.6.2",
"typescript-eslint-parser": "^14.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

干掉

"start": "egg-scripts start",
"dev": "egg-bin dev -r 'egg-ts-helper/register'",
"tsc": "ets && tsc -p tsconfig.json",
"clean": "rimraf ./app.js ./agent.js ./{app,test,config}/**/*.{js,map}",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

换为 ets clean

@atian25 atian25 mentioned this pull request Apr 1, 2018
28 tasks
@atian25 atian25 merged commit ea9de89 into master Apr 2, 2018
@atian25 atian25 deleted the ts branch April 2, 2018 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants