fix: should run restore in the current event loop

[fengmk2]

Summary by CodeRabbit

• Refactor

  • Improved performance of the restore method by executing tasks in parallel.

• Tests

  • Enhanced test suite with refined import statements, better assertion methods, and a new test case for asynchronous behavior.
  • Introduced a sleep function for testing asynchronous code execution.

[coderabbitai]

Walkthrough

The recent changes involve a refactor of the restore method within the mock object in index.js, leveraging Promise.all for parallel execution. Updates in test/mock_env.test.js include adjustments to import statements, assertion methods, and the addition of a new test case for asynchronous behavior, along with a helper sleep function to facilitate these tests.

Changes

Files	Change Summary
index.js	Refactored restore method to use Promise.all for concurrent execution of mockAgent.restore() and mm.restore().
test/mock_env.test.js	Updated import statements, assertion methods, and included a new asynchronous test along with a sleep function.

Poem

In the code, the changes ripple wide,
Restoring mock agents side by side.
Imports tweaked, assertions clear and bright,
A sleeping function for tests in the night.
Parallel paths the functions take,
To speed up tasks and faster make.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pkg-pr-new]

Run & review this pull request in StackBlitz Codeflow.

commit: d6eec43

egg-mock

npm i https://pkg.pr.new/eggjs/egg-mock@172

---

templates

• default

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 22ba637 and d6eec43.

Files selected for processing (2)

• index.js (1 hunks)
• test/mock_env.test.js (2 hunks)

Additional comments not posted (4)

test/mock_env.test.js (3)

1-2: LGTM! Explicitly importing Node.js core modules.

Updating the import statements to use node:path and node:assert improves clarity.

---

24-39: LGTM! New test case for asynchronous behavior.

The new test case effectively verifies the asynchronous behavior of mm.restore within the current event loop.

---

43-47: LGTM! New sleep function for testing asynchronous code.

The sleep function is a useful utility for testing asynchronous code.

index.js (1)

25-25: LGTM! Improved efficiency with Promise.all.

Updating the restore method to execute mockAgent.restore() and mm.restore() in parallel using Promise.all improves efficiency.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.52%. Comparing base (088ac41) to head (d6eec43).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage   85.53%   85.52%   -0.01%     
==========================================
  Files          27       27              
  Lines        2627     2626       -1     
  Branches      474      474              
==========================================
- Hits         2247     2246       -1     
  Misses        380      380              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.