fix: fix rootProtoManager.registerRootProto

not change the params order
eggjs · Aug 17, 2022 · f416ed7 · f416ed7
1 parent 00a4848
commit f416ed7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/plugin/controller/lib/RootProtoManager.ts b/plugin/controller/lib/RootProtoManager.ts
@@ -8,7 +8,8 @@ export class RootProtoManager {
   // <method, GetRootProtoCallback[]>
   protoMap: Map<string, GetRootProtoCallback[]> = new Map();
 
-  registerRootProto(method: string, host: string, cb: GetRootProtoCallback) {
+  registerRootProto(method: string, cb: GetRootProtoCallback, host: string) {
+    host = host || '';
     const cbList = MapUtil.getOrStore(this.protoMap, method + host, []);
     cbList.push(cb);
   }

diff --git a/plugin/controller/lib/impl/http/HTTPMethodRegister.ts b/plugin/controller/lib/impl/http/HTTPMethodRegister.ts
@@ -168,10 +168,10 @@ export class HTTPMethodRegister {
     const regExp = pathToRegexp(methodRealPath, {
       sensitive: true,
     });
-    rootProtoManager.registerRootProto(this.methodMeta.method, host || '', (ctx: EggContext) => {
+    rootProtoManager.registerRootProto(this.methodMeta.method, (ctx: EggContext) => {
       if (regExp.test(ctx.path)) {
         return this.proto;
       }
-    });
+    }, host || '');
   }
 }