feat: impl EggObjectLifecycle hook in decorator #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
commented
May 26, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #119 +/- ##
==========================================
+ Coverage 92.98% 93.07% +0.08%
==========================================
Files 217 219 +2
Lines 4574 4604 +30
Branches 456 462 +6
==========================================
+ Hits 4253 4285 +32
+ Misses 321 319 -2
☔ View full report in Codecov by Sentry. |
killagu
reviewed
May 26, 2023
fengmk2
commented
May 26, 2023
|
@killagu 都实现了，可以看看。 |
fengmk2
commented
May 28, 2023
fengmk2
commented
May 28, 2023
killagu
reviewed
May 28, 2023
fengmk2
commented
May 29, 2023
fengmk2
commented
May 29, 2023
| this.called.push('postInject'); | ||
| } | ||
|
|
||
| async init(): Promise<void> { | ||
| protected async init() { | ||
| this.called.push('init should not called'); |
There was a problem hiding this comment.
@killagu 这样就能将 init 释放出来又做到老代码兼容。
|
3.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #118
Checklist
npm testpassesAffected core subsystem(s)
Description of change