fix: use require.resolve instead path.join to resolve dependencies path #63

qile222 · 2022-12-06T12:10:55Z

Checklist

npm test passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

Description of change

core/common-util/src/ModuleConfig.ts

killagu

LGTM

core/common-util/src/ModuleConfig.ts

core/common-util/test/ModuleConfig.test.ts

codecov · 2022-12-08T01:55:43Z

Codecov Report

Base: 92.18% // Head: 92.18% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (75d97c9) compared to base (16640eb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         217      217           
  Lines        4363     4364    +1     
  Branches      421      420    -1     
=======================================
+ Hits         4022     4023    +1     
- Misses        340      341    +1     
+ Partials        1        0    -1

Impacted Files	Coverage Δ
core/common-util/src/ModuleConfig.ts	`75.00% <100.00%> (+0.89%)`	⬆️
plugin/orm/lib/ContextModelProto.ts	`74.07% <0.00%> (-3.71%)`	⬇️
plugin/orm/lib/DataSourceManager.ts	`53.84% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ximin.cxm added 3 commits December 6, 2022 20:09

fix: use require.resolve instead path.join to resolve dependencies path

09c76fa

feat: add tests

8450783

fix: remove only

4b997c2

fengmk2 approved these changes Dec 7, 2022

View reviewed changes

killagu reviewed Dec 7, 2022

View reviewed changes

core/common-util/src/ModuleConfig.ts Outdated Show resolved Hide resolved

killagu reviewed Dec 7, 2022

View reviewed changes

core/common-util/src/ModuleConfig.ts Outdated Show resolved Hide resolved

fix: handle require.resolve failed

47cb766

killagu approved these changes Dec 7, 2022

View reviewed changes

killagu and others added 2 commits December 7, 2022 17:23

Merge branch 'master' into master

377c87b

fix: test

378affe

qile222 commented Dec 7, 2022

View reviewed changes

core/common-util/src/ModuleConfig.ts Show resolved Hide resolved

Merge branch 'master' into master

2a4030a

killagu reviewed Dec 8, 2022

View reviewed changes

core/common-util/test/ModuleConfig.test.ts Outdated Show resolved Hide resolved

Update core/common-util/test/ModuleConfig.test.ts

75d97c9

killagu merged commit d7f3beb into eggjs:master Dec 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use require.resolve instead path.join to resolve dependencies path #63

fix: use require.resolve instead path.join to resolve dependencies path #63

qile222 commented Dec 6, 2022

killagu left a comment

codecov bot commented Dec 8, 2022 •

edited

Loading

fix: use require.resolve instead path.join to resolve dependencies path #63

fix: use require.resolve instead path.join to resolve dependencies path #63

Conversation

qile222 commented Dec 6, 2022

Checklist

Affected core subsystem(s)

Description of change

killagu left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 8, 2022 • edited Loading

Codecov Report

codecov bot commented Dec 8, 2022 •

edited

Loading