fix: use require.resolve instead path.join to resolve dependencies path

core/common-util/src/ModuleConfig.ts

@@ -145,7 +145,7 @@ export class ModuleConfigUtil {
     return ref;
   }
 
-  private static readModuleFromNodeModules(baseDir: string) {
+  public static readModuleFromNodeModules(baseDir: string) {
     const ref: ModuleReference[] = [];
     let pkgContent: string;
     try {
@@ -154,11 +154,16 @@ export class ModuleConfigUtil {
       return [];
     }
     const pkg = JSON.parse(pkgContent);
-    if (!fs.existsSync(path.join(baseDir, '/node_modules'))) {
-      return ref;
-    }
     for (const dependencyKey of Object.keys(pkg.dependencies || {})) {
-      const absolutePkgPath = path.join(baseDir, '/node_modules', dependencyKey);
+      let packageJsonPath: string;
+      try {
+        // https://nodejs.org/api/packages.html#package-entry-points
+        // ignore cases where the package entry is exports but package.json is not exported
+        packageJsonPath = require.resolve(`${dependencyKey}/package.json`, { paths: [ baseDir ] });
+      } catch (_) {
+        continue;
+      }
+      const absolutePkgPath = path.dirname(packageJsonPath);
       const realPkgPath = fs.realpathSync(absolutePkgPath);
       try {
         if (this.readModuleNameSync(realPkgPath)) {

core/common-util/test/ModuleConfig.test.ts

@@ -15,6 +15,7 @@ describe('test/ModuleConfig.test.ts', () => {
       it('should work', () => {
         const fixturesPath = path.join(__dirname, './fixtures/apps/app-with-no-module-json');
         const ref = ModuleConfigUtil.readModuleReference(fixturesPath);
+        console.log(333, ref);
         assert.deepStrictEqual(ref, [
           { path: path.join(fixturesPath, 'app/module-a') },
           { path: path.join(fixturesPath, 'app/module-b') },
@@ -62,4 +63,37 @@ describe('test/ModuleConfig.test.ts', () => {
       });
     });
   });
+
+  describe('read package dependencies', () => {
+
+    it('should success if package.json not exist', async () => {
+      const dir = path.resolve(__dirname, './fixtures/monorepo/foo');
+      const ret = ModuleConfigUtil.readModuleFromNodeModules(dir);
+      assert.deepStrictEqual(ret, []);
+    });
+
+    it('should success whether dependencies entry has exported package.json', async () => {
+      const dir = path.resolve(__dirname, './fixtures/monorepo/packages/d');
+      const ret = ModuleConfigUtil.readModuleFromNodeModules(dir);
+      assert.deepStrictEqual(ret, [{
+        path: path.resolve(__dirname, './fixtures/monorepo/packages/d/node_modules/e'),
+      }]);
+    });
+
+    it('should read dependencies from self node_modules', async () => {
+      const dir = path.resolve(__dirname, './fixtures/monorepo/packages/a');
+      const ret = ModuleConfigUtil.readModuleFromNodeModules(dir);
+      assert.deepStrictEqual(ret, [{
+        path: path.resolve(__dirname, './fixtures/monorepo/packages/a/node_modules/c'),
+      }]);
+    });
+
+    it('should read dependencies from parent node_modules', async () => {
+      const dir = path.resolve(__dirname, './fixtures/monorepo/packages/b');
+      const ret = ModuleConfigUtil.readModuleFromNodeModules(dir);
+      assert.deepStrictEqual(ret, [{
+        path: path.resolve(__dirname, './fixtures/monorepo/packages/a'),
+      }]);
+    });
+  });
 });

core/common-util/test/fixtures/monorepo/packages/a/package.json

@@ -0,0 +1,10 @@
+{
+  "eggModule": {
+    "name": "a"
+  },
+  "dependencies": {
+    "c": "*"
+  },
+  "name": "b",
+  "author": ""
+}

core/common-util/test/fixtures/monorepo/packages/b/package.json

@@ -0,0 +1,10 @@
+{
+  "eggModule": {
+    "name": "b"
+  },
+  "dependencies": {
+    "a": "*"
+  },
+  "name": "b",
+  "author": ""
+}

core/common-util/test/fixtures/monorepo/packages/d/package.json

@@ -0,0 +1,11 @@
+{
+  "eggModule": {
+    "name": "d"
+  },
+  "dependencies": {
+    "e": "*",
+    "f": "*"
+  },
+  "name": "d",
+  "author": ""
+}