Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BackgroundTaskHelper should support recursively call #90

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Feb 2, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 92.75% // Head: 92.75% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c6bdc32) compared to base (b47d151).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files         214      214           
  Lines        4512     4516    +4     
  Branches      458      459    +1     
=======================================
+ Hits         4185     4189    +4     
  Misses        327      327           
Impacted Files Coverage Δ
core/background-task/src/BackgroundTaskHelper.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@killagu killagu merged commit 368ac03 into master Feb 2, 2023
@killagu killagu deleted the fix/recursive_background_task branch February 2, 2023 06:06
await app.mockModuleContextScope(async ctx => {
ctx.runInBackground(async () => {
await sleep(100);
ctx.runInBackground(async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

实现了无限嵌套。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants