fix: add isDirectory property

eggjs · Jan 11, 2025 · ff45ffe · ff45ffe
1 parent 17b20df
commit ff45ffe
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 1 deletion.
diff --git a/src/lib/event-sources/development.ts b/src/lib/event-sources/development.ts
@@ -89,10 +89,12 @@ export default class DevelopmentEventSource extends BaseEventSource {
     //    mtime: Wed Jun 17 2015 00:08:38 GMT+0800 (CST),
     //    ctime: Wed Jun 17 2015 00:08:38 GMT+0800 (CST),
     //    birthtime: Tue Jun 16 2015 23:19:13 GMT+0800 (CST) } }
+    const stat = fs.statSync(file, { throwIfNoEntry: false });
     const info = {
       path: file,
       event,
-      stat: fs.statSync(file, { throwIfNoEntry: false }),
+      stat,
+      isDirectory: stat?.isDirectory(),
     } as ChangeInfo;
     this.emit('change', info);
   }

diff --git a/src/lib/types.ts b/src/lib/types.ts
@@ -21,6 +21,7 @@ export interface ChangeInfo extends Record<string, any> {
    */
   stat?: Stats;
   path: string;
+  isDirectory?: boolean;
 }
 
 declare module '@eggjs/core' {

diff --git a/test/development.test.ts b/test/development.test.ts
@@ -59,6 +59,13 @@ describe('test/development.test.ts', () => {
     count = parseInt(res.text);
     assert(count > lastCount, `count: ${count}, lastCount: ${lastCount}`);
 
+    await app.httpRequest()
+      .get('/app-hasDir')
+      .expect(200)
+      .expect({
+        hasDir: false,
+      });
+
     /*
     // TODO wait unsubscribe implementation of cluster-client
     await request(server)

diff --git a/test/fixtures/apps/watcher-development-app/app/router.js b/test/fixtures/apps/watcher-development-app/app/router.js
@@ -5,10 +5,14 @@ const dir_path = path.join(__dirname, '../tmp');
 
 module.exports = function(app) {
   let fileChangeCount = 0;
+  let hasDir = false;
 
   function callback(info) {
     console.log('got change %j', info);
     fileChangeCount++;
+    if (info.isDirectory) {
+      hasDir = true;
+    }
   }
 
   app.get('/app-watch', async ctx => {
@@ -25,6 +29,12 @@ module.exports = function(app) {
     ctx.body = fileChangeCount;
   });
 
+  app.get('/app-hasDir', async ctx => {
+    ctx.body = {
+      hasDir,
+    };
+  });
+
   app.get('/agent-watch', async ctx => {
     app.messenger.broadcast('agent-watch');
     ctx.body = await new Promise(function(resolve) {