Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toggle sidebar children #223

Merged
merged 9 commits into from
May 11, 2019
Merged

Conversation

ittus
Copy link
Contributor

@ittus ittus commented May 10, 2019

Implement #216

sidebar

@egoist Please help to review when you have time 🙇

@egoist
Copy link
Owner

egoist commented May 11, 2019

屏幕快照_2019-05-11_下午2_12_41

It should allow us to toggle these items instead.

@egoist
Copy link
Owner

egoist commented May 11, 2019

ddd

Add a collapsable to the sidebar item, and make it default to false

@ittus
Copy link
Contributor Author

ittus commented May 11, 2019

@egoist
Thank for your explanation. I've updated the code. Please help to review again!

@egoist
Copy link
Owner

egoist commented May 11, 2019

Looks good, but it should hide the children by default if collapsable is true

@ittus
Copy link
Contributor Author

ittus commented May 11, 2019

Fixed 😄

@egoist
Copy link
Owner

egoist commented May 11, 2019

We should also expand the children when the current route is one of the children.

屏幕快照_2019-05-11_下午3_43_16

And collapse other collapsable items.

Check out the VuePress example.

@ittus
Copy link
Contributor Author

ittus commented May 11, 2019

Fixed! But I don't know why now doesn't deploy again

@egoist egoist changed the title feat: Toggle sidebar feat: toggle sidebar children May 11, 2019
@egoist egoist merged commit 4ad0d8d into egoist:master May 11, 2019
@egoist
Copy link
Owner

egoist commented May 11, 2019

🎉 This PR is included in version 4.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ittus ittus deleted the feature/toggle-sidebar branch May 11, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants