Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brilift integration #408

Merged
merged 15 commits into from
Mar 29, 2024
Merged

Brilift integration #408

merged 15 commits into from
Mar 29, 2024

Conversation

Alex-Fischman
Copy link
Collaborator

@Alex-Fischman Alex-Fischman commented Mar 24, 2024 •
edited
Loading

Adds RunType::Compile and Interpretable::Executable to util.rs, which calls into brilift to compile and run the program.

Resolves #385.

@Alex-Fischman Alex-Fischman requested a review from oflatt March 24, 2024 02:21
oflatt
oflatt requested changes Mar 24, 2024
View reviewed changes
Copy link
Member

@oflatt oflatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Had some minor questions

src/util.rs Outdated Show resolved Hide resolved
infra/brilift.c Outdated Show resolved Hide resolved
@Alex-Fischman Alex-Fischman changed the base branch from main to oflatt-dag-again March 28, 2024 20:41
@Alex-Fischman Alex-Fischman requested a review from oflatt March 29, 2024 02:31
oflatt
oflatt approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@oflatt oflatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@oflatt oflatt merged commit fe2a45d into oflatt-dag-again Mar 29, 2024
4 checks passed
@oflatt oflatt deleted the brilift branch March 29, 2024 16:54
@Alex-Fischman Alex-Fischman mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oflatt oflatt oflatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add brilift integration to compile Bril to LLVM
2 participants
@Alex-Fischman @oflatt