Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(grpc)!: add wasm support and transaction client #474

Merged
merged 26 commits into from
Jan 14, 2025
Merged

feat(grpc)!: add wasm support and transaction client #474

merged 26 commits into from
Jan 14, 2025

Conversation

zvolin
Copy link
Member

@zvolin zvolin commented Dec 10, 2024

No description provided.

@zvolin zvolin requested review from oblique and fl0rek December 10, 2024 14:14
@zvolin zvolin mentioned this pull request Dec 10, 2024
Open
zvolin
zvolin commented Dec 10, 2024
View reviewed changes
grpc/src/client.rs Outdated Show resolved Hide resolved
zvolin
zvolin commented Jan 7, 2025
View reviewed changes
grpc/src/grpc.rs Show resolved Hide resolved
grpc/src/grpc/blob.rs Show resolved Hide resolved
grpc/src/grpc/tendermint.rs Show resolved Hide resolved
grpc/src/grpc/node.rs Show resolved Hide resolved
grpc/src/grpc/cosmos_tx.rs Show resolved Hide resolved
grpc/src/tx.rs Show resolved Hide resolved
zvolin
zvolin commented Jan 7, 2025
View reviewed changes
grpc/src/grpc.rs Show resolved Hide resolved
fl0rek
fl0rek reviewed Jan 9, 2025
View reviewed changes
grpc/src/grpc/celestia_tx.rs Outdated Show resolved Hide resolved
grpc/src/tx.rs Outdated Show resolved Hide resolved
proto/vendor/cosmos/bank/v1beta1/authz.proto Outdated Show resolved Hide resolved
@zvolin @fl0rek
Apply suggestions from code review
5b4ad5d 
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Signed-off-by: Maciej Zwoliński <[email protected]>
oblique
oblique reviewed Jan 9, 2025
View reviewed changes
grpc/src/tx.rs Show resolved Hide resolved
grpc/src/tx.rs Outdated Show resolved Hide resolved
grpc/src/tx.rs Outdated Show resolved Hide resolved
grpc/src/tx.rs Outdated Show resolved Hide resolved
@zvolin zvolin changed the title feat(grpc)!: enable celestia-grpc usage within wasm feat(grpc)!: add wasm support and transaction client Jan 9, 2025
@zvolin zvolin requested review from fl0rek and oblique January 13, 2025 10:12
fl0rek
fl0rek approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last comment, otherwise looks 💯 LGTM!

ci/credentials/.gitignore Show resolved Hide resolved
@zvolin @fl0rek
Update ci/credentials/.gitignore
8c352f7 
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Signed-off-by: Maciej Zwoliński <[email protected]>
@fl0rek fl0rek merged commit 4c2187c into eigerco:main Jan 14, 2025
29 checks passed
@zvolin zvolin deleted the feat/grpc-wasm-support branch January 14, 2025 10:24
This was referenced Jan 14, 2025
Closed
Closed
Closed
Closed
This was referenced Jan 21, 2025
Closed
Closed
Closed
@zvolin zvolin mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oblique oblique oblique approved these changes

@fl0rek fl0rek fl0rek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvolin @oblique @fl0rek