Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfc: Add P2P info exchange #713

Merged
merged 4 commits into from
Feb 4, 2025
Merged

rfc: Add P2P info exchange #713

merged 4 commits into from
Feb 4, 2025

Conversation

aidan46
Copy link
Contributor

@aidan46 aidan46 commented Jan 31, 2025 •
edited
Loading

Description

Add an RFC for adding the P2P bootstrap node into the collator as a service.

@aidan46 aidan46 self-assigned this Jan 31, 2025
@aidan46 aidan46 added the rfc Request for Comments (RFC) label Jan 31, 2025
@aidan46 aidan46 added this to the Phase 3 milestone Jan 31, 2025
@aidan46 aidan46 linked an issue Jan 31, 2025 that may be closed by this pull request
rfc: P2P Information exchange improvement #714
Closed
@aidan46 aidan46 added the ready for review Review is needed label Feb 3, 2025
@aidan46 aidan46 marked this pull request as ready for review February 3, 2025 04:11
jmg-duarte
jmg-duarte reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some redundancy that could be cut down.

One thing that is not covered is how to get the collators addresses from each other, covering that detail is important.

rfcs/004-p2p-information-exchange.md Outdated Show resolved Hide resolved
rfcs/004-p2p-information-exchange.md Outdated Show resolved Hide resolved
rfcs/004-p2p-information-exchange.md Outdated Show resolved Hide resolved
rfcs/004-p2p-information-exchange.md Outdated Show resolved Hide resolved
rfcs/004-p2p-information-exchange.md Outdated Show resolved Hide resolved
rfcs/004-p2p-information-exchange.md Outdated Show resolved Hide resolved
th7nder
th7nder previously approved these changes Feb 3, 2025
View reviewed changes
rfcs/004-p2p-information-exchange.md Outdated Show resolved Hide resolved
@aidan46 aidan46 requested review from jmg-duarte and th7nder February 4, 2025 08:57
@aidan46 aidan46 added ready for review Review is needed and removed ready for review Review is needed labels Feb 4, 2025
jmg-duarte
jmg-duarte approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job! :shipit:

@jmg-duarte jmg-duarte enabled auto-merge (squash) February 4, 2025 09:48
@jmg-duarte jmg-duarte merged commit a7f05f2 into develop Feb 4, 2025
6 checks passed
@jmg-duarte jmg-duarte deleted the rfc/p2p-improvement branch February 4, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th7nder th7nder th7nder approved these changes

@jmg-duarte jmg-duarte jmg-duarte approved these changes

@cernicc cernicc Awaiting requested review from cernicc

@Jinxit Jinxit Awaiting requested review from Jinxit

@pete-eiger pete-eiger Awaiting requested review from pete-eiger

Assignees

@aidan46 aidan46

Labels
ready for review Review is needed rfc Request for Comments (RFC)
Projects
None yet
Milestone
Phase 3
Development

Successfully merging this pull request may close these issues.

rfc: P2P Information exchange improvement
3 participants
@aidan46 @th7nder @jmg-duarte