Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: polkadot nix build fails due to clang std=c++17 on MacOS #730

Merged
merged 2 commits into from
Feb 5, 2025
Merged

fix: polkadot nix build fails due to clang std=c++17 on MacOS #730

merged 2 commits into from
Feb 5, 2025

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Feb 5, 2025

Description

Workarounds andresilva/polkadot.nix#36 & NixOS/nixpkgs#323869 (comment).
Details in the code and issues.

Checklist

  • Are there important points that reviewers should know?
  • Make sure that you described what this change does.
  • Have you tested this solution?

@th7nder th7nder added the bug Something isn't working label Feb 5, 2025
@th7nder th7nder added this to the Phase 3 milestone Feb 5, 2025
@th7nder th7nder self-assigned this Feb 5, 2025
@aidan46 aidan46 enabled auto-merge (squash) February 5, 2025 03:56
@aidan46 aidan46 merged commit f571751 into develop Feb 5, 2025
6 checks passed
@aidan46 aidan46 deleted the fix/no-ref/cc-rs branch February 5, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cernicc cernicc cernicc approved these changes

@aidan46 aidan46 aidan46 approved these changes

@jmg-duarte jmg-duarte Awaiting requested review from jmg-duarte

Assignees

@th7nder th7nder

Labels
bug Something isn't working
Projects
None yet
Milestone
Phase 3
Development

Successfully merging this pull request may close these issues.
3 participants
@th7nder @cernicc @aidan46