explicit reporting for e2e tests failing for code problems

eighty4 · Oct 16, 2024 · 17ada1b · 17ada1b
1 parent d8b3bae
commit 17ada1b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
@@ -38,6 +38,12 @@ jobs:
       run: |
         corepack enable && corepack prepare pnpm@latest --activate
         pnpm i
+    - name: typecheck frontend
+      run: pnpm exec tsc --build
+      working-directory: frontend
+    - name: typecheck offline
+      run: pnpm exec tsc --build
+      working-directory: offline
     - name: playwright
       env:
         CI: true

diff --git a/e2e/start_app.sh b/e2e/start_app.sh
@@ -1,7 +1,12 @@
 #!/bin/bash
+set -e
 
 pushd ../frontend
-  pnpm build:tsc
+  pnpm exec tsc --build
+popd
+
+pushd ../offline
+  pnpm exec tsc --build
 popd
 
 pushd ../offline