Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mp4 files are not playing in browser #1328

Closed
albertbern opened this issue Feb 19, 2024 · 10 comments
Closed

mp4 files are not playing in browser #1328

albertbern opened this issue Feb 19, 2024 · 10 comments
Labels
Milestone

Comments

@albertbern
Copy link

albertbern commented Feb 19, 2024

mp4 files are not playing in browser

ver 1.13.1

logs:

Feb 19 18:53:52   sharry-restserver[815078]: 2024.02.19 18:53:52:0000 [io-comp...] [INFO ] org.http4s.server.middleware.Logger - HTTP/1.1 GET /api/v2/open/share/AmWPnFULrUC-qG6bPXeV1jd-d4qyp6UhrnN-Xar5UudJ4kP/file/9bFpMzPmxG1-eiBsLa56wcE-KcbJMLPXdS2-44NhNjT52x6
Feb 19 18:53:52   sharry-restserver[815078]: 2024.02.19 18:53:52:0001 [io-comp...] [INFO ] org.http4s.server.middleware.Logger - HTTP/1.1 206 Partial Content

- - [19/Feb/2024:18:53:52 +0200] "GET /api/v2/open/share/AmWPnFULrUC-qG6bPXeV1jd-d4qyp6UhrnN-Xar5UudJ4kP/file/9bFpMzPmxG1-eiBsLa56wcE-KcbJMLPXdS2-44NhNjT52x6 HTTP/1.1" 206 135428 "XXXXXX/app/open/AmWPnFULrUC-qG6bPXeV1jd-d4qyp6UhrnN-Xar5UudJ4kP?view=1" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36"

@eikek
Copy link
Owner

eikek commented Feb 20, 2024

What is happening instead in the browser? Can you see error messages in the browser console? I just tried on my (still 1.13.0) installation and mp4 files are playing fine (firefox).

@albertbern
Copy link
Author

No errors - GET Status Code: 206 Partial Content
Chrome - does not play
Edge - does not play
It works only in firefox

@albertbern
Copy link
Author

Chrome and Edge - small player window appears and it become inactive in a sec.

Player in Firefox works only by downloading file from the start. Is it possible to have player that can start from any position?
User mp4 files are huge.

@eikek
Copy link
Owner

eikek commented Feb 24, 2024

I see, thank you for checking. I need to investigate, I could play my files well, but they weren't very big.

@kqfflo
Copy link

kqfflo commented Feb 27, 2024

I was about to open a case myself as I seem to have the same issue.
Maybe this helps a little:
I still need to stick with 1.12.1 . Starting with 1.13.x videoplayback stopped working.

Loglevel trace does not reveal any additional details:

2024.02.27 14:36:45:0006 [io-comp...] [DEBUG] com.zaxxer.hikari.pool.PoolBase - HikariPool-1 - Reset (autoCommit) on connection org.mariadb.jdbc.Connection@5177f61d 2024.02.27 14:36:45:0000 [io-comp...] [INFO ] org.http4s.server.middleware.Logger - HTTP/1.1 GET /api/v2/sec/share/FtE8wuKEfu2-QGV8rZ23o74-z6p89drmGBe-EkjwyGrrpqo/file/2tHUFvk5bJv-amiq9SwKg3m-oMZZxTpLget-DnHfp9AVL5e 2024.02.27 14:36:45:0001 [io-comp...] [INFO ] org.http4s.server.middleware.Logger - HTTP/1.1 206 Partial Content

Also the dev cnsole does not bring up anything meaningful or error.

@albertbern Can you maybe check and see, if 1.12.1 works for you? (you can use the same database as with 1.13.x - but have a backup)

@eikek
Copy link
Owner

eikek commented Feb 27, 2024

Thanks @kqfflo , this is always very helpful!

@albertbern
Copy link
Author

Can confirm, 1.12.1 works.
1.13.* are not.

@eikek eikek added the bug label Mar 2, 2024
eikek added a commit that referenced this issue Mar 2, 2024
Use a fixed chunk-size in case the request specifies an open range
which would mean to transport the entire file. In this case, the
client gets some smaller chunk as it is already indicating to
understand range responses. If a file is smaller than this chunksize,
it will be a normal response.

Fixes: #1328
@mergify mergify bot closed this as completed in f010e3a Mar 2, 2024
@eikek
Copy link
Owner

eikek commented Mar 2, 2024

Hi, I pushed a fix - it will be in the snapshot releases shortly. If you could perhaps test it and report back, that would be great!

@eikek eikek added this to the Sharry 1.13.2 milestone Mar 5, 2024
@kqfflo
Copy link

kqfflo commented Mar 10, 2024

I can confirm that this fixed the issue. Using 1.14.SNAPSHOT now.
This fix is highly appreciated - thank you!

@eikek
Copy link
Owner

eikek commented Mar 10, 2024

Thank you @kqfflo for reporting back! I will make a bug-fix release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants