feat(sgae): remove deprecated go-review target

einride · May 2, 2024 · 13e88e6 · 13e88e6
1 parent f09410b
commit 13e88e6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/.sage/main.go b/.sage/main.go
@@ -8,7 +8,6 @@ import (
 	"go.einride.tech/sage/tools/sggit"
 	"go.einride.tech/sage/tools/sggo"
 	"go.einride.tech/sage/tools/sggolangcilint"
-	"go.einride.tech/sage/tools/sggoreview"
 	"go.einride.tech/sage/tools/sgmdformat"
 	"go.einride.tech/sage/tools/sgyamlfmt"
 )
@@ -24,7 +23,7 @@ func main() {
 
 func All(ctx context.Context) error {
 	sg.Deps(ctx, ConvcoCheck, FormatMarkdown, FormatYAML)
-	sg.Deps(ctx, GoLint, GoReview)
+	sg.Deps(ctx, GoLint)
 	sg.Deps(ctx, SpannerGenerate)
 	sg.SerialDeps(ctx, GoTest, GoModTidy, GitVerifyNoDiff)
 	return nil
@@ -45,11 +44,6 @@ func GoTest(ctx context.Context) error {
 	return sggo.TestCommand(ctx).Run()
 }
 
-func GoReview(ctx context.Context) error {
-	sg.Logger(ctx).Println("reviewing Go files...")
-	return sggoreview.Command(ctx, "-c", "1", "./...").Run()
-}
-
 func GoLint(ctx context.Context) error {
 	sg.Logger(ctx).Println("linting Go files...")
 	return sggolangcilint.Run(ctx)

diff --git a/Makefile b/Makefile
@@ -71,10 +71,6 @@ go-lint: $(sagefile)
 go-mod-tidy: $(sagefile)
 	@$(sagefile) GoModTidy
 
-.PHONY: go-review
-go-review: $(sagefile)
-	@$(sagefile) GoReview
-
 .PHONY: go-test
 go-test: $(sagefile)
 	@$(sagefile) GoTest