Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more datatypes functions #8

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

etiennebacher
Copy link
Contributor

This just adds is_date() and is_nested_null(), the rest is just reordering alphabetically

@eitsupi
Copy link
Owner

eitsupi commented Oct 10, 2024

Thank you. I think the original order was copied from py-polars, I don't think py-polars has is_nested_null(), do you think that is worth adding?

(I'm heading out now, so review may be 24 hours away)

@etiennebacher
Copy link
Contributor Author

Yes, I just find it easier to see what's missing by going alphabetically.

They have is_nested_null here: https://github.com/pola-rs/polars/blob/0870a5dbe935c98c38d35f78431e69caa3102591/crates/polars-core/src/datatypes/dtype.rs#L646

I don't have a usecase for now, it's just for completeness.

Copy link
Owner

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's marge for now.

@eitsupi eitsupi changed the title Add more datatypes functions feat: add more datatypes functions Oct 11, 2024
@eitsupi eitsupi merged commit d5994dc into eitsupi:main Oct 11, 2024
@eitsupi
Copy link
Owner

eitsupi commented Oct 13, 2024

They have is_nested_null here: pola-rs/polars@0870a5d/crates/polars-core/src/datatypes/dtype.rs#L646

It says that is_nested_null does not support Array of Null.
I opened pola-rs/polars#19219

@etiennebacher etiennebacher deleted the more-types branch October 14, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants