-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to use gWCS #327
Comments
I think that should be straightforward, given that we already have the pluggable WCS support. I note from the link that |
Thanks, that sounds promising! Unfortunately, Mike D. is no longer at STScI. Do you happen to have a copy of his hack? |
According to @nden , for uncalibrated JWST data, Astropy WCS will not be able to read the distortion information but GWCS can. |
Update: After some internal discussions, it looks like I might have to move this one to |
Given the community interest in gWCS, it seems like it would be useful to have that as a WCS option in Ginga. But perhaps it can be added later copying the approach in |
My understanding so far is that it is only useful if you have data model schemas to go with it (e.g. schemas embedded in JWST pipeline). Discussion is still ongoing. Hopefully I'll know more next week. Thanks for your patience. |
@pllim It's more like, if you want to display JWST raw data you will need the jwst package installed. |
Exactly. It only works with schemas. And currently only JWST uses it (and perhaps SunPy but in a different way). I can't envision how to support such a thing in a generic way over here. It is not like FITS WCS where all you need is a header (for better or worse). Might be better to contain this in |
Update: @hcferguson has decided that it is best to hold this off until astropy/astropy#7326 and its counterpart for GWCS (spacetelescope/gwcs#146) is merged. FYI. Thank you for your continued patience. |
Sounds reasonable. |
APE 14 is done -- http://docs.astropy.org/en/latest/wcs/wcsapi.html |
@mcara suggested that Ginga should add the option to support gWCS (https://github.com/spacetelescope/gwcs) for future JWST support. I am just opening an issue here so I don't forget that this request happened.
c/c @larrybradley, @nden, @stscieisenhamer
The text was updated successfully, but these errors were encountered: