WIP: Ginga viewer for ASDF #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sosey , I believe |
|
@pllim should we go ahead and merge this? |
|
I don't remember what this was for now... And "from unknown repository" looks sketchy. Did I delete my fork?! |
|
Also ejeschke/ginga#327 is still not merged yet, so I don't think this can be merged regardless. |
|
I'm gunna close this then....you can open another one if it becomes relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternate approach to spacetelescope/stginga#157 . Depends on spacetelescope/gwcs#146 and ejeschke/ginga#327 .
c/c @hcferguson