EXP: Support JWST ASDF-in-FITS in reference viewer #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
commented
Jul 27, 2019
| @@ -226,15 +226,18 @@ def datapt_to_system(self, datapt, system=None, coords='data', | |||
| """ | |||
| if self.coordsys == 'raw': | |||
| raise common.WCSError("No usable WCS") | |||
| elif self.coordsys == 'world': | |||
There was a problem hiding this comment.
This is necessary for WCSAxes plugin to work for GWCS generated by JWST data.
Merged
ejeschke
approved these changes
Jul 31, 2019
ginga/AstroImage.py
Outdated
| except Exception: | ||
| tb_str = "Traceback information unavailable." | ||
| self.logger.error(tb_str) | ||
| self.logger.warning(tb_str) |
There was a problem hiding this comment.
Yeah, this was a leftover from my attempt to silence the bad WCS calculations, as GWCS returns nan for RA and Dec for pixels outside of image bounds. It didn't really work as I thought it would anyway, so I will go ahead and revert this change here. Thanks for catching it.
Generalize data and WCS lookup in ASDF more. [skip appveyor]
pllim
force-pushed
the
jwst-asdf-pyastro2019
branch
from
43de0bd to
281c852
Compare
|
@ejeschke , given your approval above, I am going to take the liberty to merge this in. I have removed the unnecessary changing from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to discuss how to best generalize the ASDF loading in reference viewer. This might change depending on how #764 goes (currently does not depend on it).Will just roll with this and follow up in a separate PR after #764 is rebased on this and merged.These are the changes necessary for Python in Astronomy 2019 demo using Ginga standalone GUI (reference viewer) to view ASDF-in-FITS data file generated by JWST. Follow up of #719. Also see spacetelescope/stginga#155
cc @jdavies-st (in case you are interested), @hcferguson , and @eteq
Figure out why compass inPanappears weird for the ASDF extension, but not FITS. Maybe spacetelescope/gwcs#241 ?Future work:
NaN, but instead silently format the string to something equivalent (the default "BAD WCS" is probably a little misleading in this case). See "BAD WCS" error is too verbose #782