Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added required support for ViZX Extension #469

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Added required support for ViZX Extension #469

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2669c7
added code so goals can be passed to the vizx extension when it is ac…
bhaktishh Mar 26, 2023
5b5a9ac
removed comment
bhaktishh Mar 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion editor/code/src/goals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Position, Uri, WebviewPanel, window, ViewColumn } from "vscode";
import { Position, Uri, WebviewPanel, window, ViewColumn, extensions, commands } from "vscode";
import {
BaseLanguageClient,
RequestType,
Expand Down Expand Up @@ -78,6 +78,10 @@ export class InfoPanel {
// notify the info panel that we have fresh goals to render
requestDisplay(goals: GoalAnswer<PpString>) {
this.postMessage("renderGoals", goals);
let vizx = extensions.getExtension("inQWIRE.vizx");
if (vizx?.isActive) {
commands.executeCommand("vizx.lspRender", goals);
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as a prototype, will merge so you can continue your testing.

I propose we indeed move towards a registration mechanism like done in most parts of VSCode, so eventually we can replace this code with your extension doing in activation:

let coq-lsp = extensions.getExtension("coq-lsp").?API_v1
coq-lsp.registerGoalProcessorString((goals) => lspRender(goals))

We may need a bit different API once we need to properly manage the UI resources both extensions handle, but that should be a good start.

}

// notify the info panel that we found an error
Expand Down