[plugins] Fix the output of the AST dump plugin to be valid JSON #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @blackbird1128 , sorry for the delay in answering this, I was thinking of a different solution, namely changing the output format to be .jsonl (https://jsonlines.org/) What do you think? Usually this is more convenient for JSON parsers, which tend no to be incremental enough. p.s: Are you OK to put your real name in the CHANGES.md file? Let me know if not what id you would prefer. |
|
Hello, no problem ! Yes, this is also fine, I can also sign commits if needed will try to do so in the future, not sure about how to do that retro-actively tho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the output produced by the AST dump plugin to output valid JSON.