Adapt to coq/coq#19901 (relocatable mode) #891
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
reviewed
Jan 16, 2025
| let cmdline : Coq.Workspace.CmdLine.t = | ||
| { coqlib = Coq_config.coqlib | ||
| ; coqcorelib = Filename.concat Coq_config.coqlib "../rocq-runtime" | ||
| { coqlib = conf_coqlib |
There was a problem hiding this comment.
Seems to me like this should be the same time than the one in coq_config, but see my comment in the original PR.
There was a problem hiding this comment.
Not seeing which comment you mean
There was a problem hiding this comment.
Sorry it wasn't sent yet went I wrote this. I'm happy consuming the new variant type, and following the spec at my side. I'm also happy for coq-lsp to error on relocatable so we don't block on coq-lsp implementing the spec, but we need a spec.
This doesn't feel very satisfying but IDK what else to do.
SkySkimmer
force-pushed
the
configure-clean
branch
from
be4f2fe to
5901697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't feel very satisfying but IDK what else to do.