Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create fibonnaci search.c #56

Merged
merged 3 commits into from
Oct 3, 2020
Merged

Create fibonnaci search.c #56

merged 3 commits into from
Oct 3, 2020

Conversation

avnishsingh516
Copy link
Contributor

No description provided.

@avnishsingh516 avnishsingh516 mentioned this pull request Oct 3, 2020
Closed
@ekdnam
Copy link
Owner

ekdnam commented Oct 3, 2020

LGTM!

Two things

  • Rename the file to fibonacciSearch.c
  • Rename the function to fibonaccISearch()

GFG has fibMonacci, but here we want fibonacci 😄

@avnishsingh516
Copy link
Contributor Author

i changed the function name and file name

@avnishsingh516
Update fibonacciSearch.c
5fb5afb 
made the input dynamic
@avnishsingh516
Copy link
Contributor Author

final changes. i made the input dynamic and changes the file and function name also.
Please, review

@ekdnam
Copy link
Owner

ekdnam commented Oct 3, 2020

LGTM! Thanks for your contribution! Merging into master

@ekdnam ekdnam merged commit 5cb6926 into ekdnam:c Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avnishsingh516 @ekdnam