Add build status #11
Add build status #11
Conversation
|
Sorry about the delay here — this is pretty cool! Could you share a screenshot? |
|
@ekmartin I need a new review before this stuff can get merged but I'm also considering adding the icons to this repo as well as adding instructions on how to add slack emoji to the setup instructions as the default ones look pretty bad. At which point I think setup might be easier if instead of an emoji i make it a url to an image hosted somewhere, opinions? |
|
@ekmartin yeah i guess Review required permission is still set even for collaborators. |
|
hey @ekmartin I have a lot of plans for stuff I want to do with this repo, and you have the primo pip slug so I'd rather continue the project, would you consider moving this repo to an open source org like https://jazzband.co/ and adding me as a maintainer? Otherwise I'll be starting my own fork. |
|
If we can find a set of default emojis that look alright here I'd prefer not having configuration options for this at all. Opinionated is usually better than overly configurable and I think it's worth trying to keep the options to a minimum. Regarding the maintainer question: I added you as a collaborator a while back, but it says it's awaiting your response. With that being said, I still prefer that all changes go through a pull request reviewed by at least one person. I'd definitely be open to moving the project to something like Jazzband, but I don't think that would change anything in terms of reviews and merging code — it would also definitely need things like tests first to follow the Jazzband guidelines.
|
|
Yea, you're right, this may be too much customizability.... hadn't thought of that. |
Screenshot of what it looks like:
