Explicitly define sconcat on ByteString to use Data.ByteString.concat #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
reviewed
Feb 20, 2018
src-ghc7/Data/Semigroup.hs
Outdated
| @@ -172,8 +172,8 @@ import Data.Tagged | |||
| #endif | |||
|
|
|||
| #ifdef MIN_VERSION_text | |||
| import qualified Data.Text as Strict | |||
| import qualified Data.Text.Lazy as Lazy | |||
| import qualified Data.Text as Strict hiding (concat) | |||
There was a problem hiding this comment.
This is a bit of a gnarly way to accomplish this. Why not just change the qualified imports for Data.Text and Data.Text.Lazy from Strict and Lazy to TS and TL? (Similarly, BS and BL for Data.ByteString and Data.ByteString.Lazy.)
There was a problem hiding this comment.
Sure, I'm happy to do that. I thought I would go for a smaller diff for such a minor change, but I agree that changing the imports is cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a pull request for this in bytestring as well haskell/bytestring#142