Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to Modulesync 5.3.0 PR #1

Closed
wants to merge 3 commits into from

Conversation

Rathios
Copy link

@Rathios Rathios commented Aug 12, 2022

All tests are passing on my Fedora 36 box with these changes.

  • Adds net-ftp as a dependency gem for testing on Fedora. Fresh Ruby 3.1 on Fedora does not include this gem, making tests related to apt_key fail. Not sure if this is a Fedora problem or a test suite problem.
  • Fixes Zabbix Agent and Server tests concerning OSes that have since moved to systemd. These can't have worked in a long time.
  • Temporarily disables Gentoo tests. Support for Gentoo is broken and I don't have the means to fix it. Gentoo is still in metadata.json. Users should have complained by now if it mattered. Whoever wants to fix it can fix the spec tests at the same time.

@ekohl
Copy link
Owner

ekohl commented Aug 22, 2022

Adds net-ftp as a dependency gem for testing on Fedora. Fresh Ruby 3.1 on Fedora does not include this gem, making tests related to apt_key fail. Not sure if this is a Fedora problem or a test suite problem.

Resolved in puppetlabs/puppetlabs-apt#1050.

So I only picked the 2 other commits.

@ekohl ekohl closed this Aug 22, 2022
ekohl pushed a commit that referenced this pull request Nov 6, 2023
rebase on current master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants