Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cluster AutoScaler as an Addon #170

Closed
christopherhein opened this issue Aug 21, 2018 · 3 comments
Closed

Add Cluster AutoScaler as an Addon #170

christopherhein opened this issue Aug 21, 2018 · 3 comments
Labels
area/add-ons help wanted Extra attention is needed kind/feature New feature or request

Comments

@christopherhein
Copy link
Contributor

Needs to add the following policy to the instance role:

{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
                "autoscaling:DescribeAutoScalingGroups",
                "autoscaling:DescribeAutoScalingInstances",
                "autoscaling:SetDesiredCapacity",
                "autoscaling:TerminateInstanceInAutoScalingGroup"
            ],
            "Resource": "*"
        }
    ]
}

Apply the CA manifest file with the autoscaling group prefilled.

@errordeveloper
Copy link
Contributor

errordeveloper commented Aug 21, 2018

I think we should be able to cater for this very easily once #132 lands. So we can add IAM role changes (perhaps as a flag) in 0.1.x (and document usage), and then implement actual add-on in 0.2.x, when we have proper way of managing add-ons.

@errordeveloper errordeveloper added this to the 0.1.x – improvements milestone Aug 21, 2018
@richardcase richardcase added kind/feature New feature or request and removed kind/feature labels Aug 30, 2018
Lazyshot pushed a commit that referenced this issue Oct 16, 2018
Adds the ability and flag for requesting the necessary
policy for the cluster-autoscaler application. This will
be revisited once the add-on work is done.

Issue #170
Lazyshot pushed a commit that referenced this issue Oct 16, 2018
Adds the ability and flag for requesting the necessary
policy for the cluster-autoscaler application. This will
be revisited once the add-on work is done.

Issue #170
@Lazyshot Lazyshot added help wanted Extra attention is needed hacktoberfest labels Oct 17, 2018
Lazyshot pushed a commit that referenced this issue Oct 17, 2018
Adds the ability and flag for requesting the necessary
policy for the cluster-autoscaler application. This will
be revisited once the add-on work is done.

Issue #170
Lazyshot pushed a commit that referenced this issue Oct 17, 2018
Adds the ability and flag for requesting the necessary
policy for the cluster-autoscaler application. This will
be revisited once the add-on work is done.

Issue #170
@mumoshu
Copy link
Contributor

mumoshu commented Nov 30, 2018

As similar as I wrote in #242 (comment), I'm personally fine as long as eksctl adds necessary IAM perms to the role.

Based on my experience in kube-aws, users occasionally wanted to update just a subset of installed addons, like in this case just adding a flag to cluster-autoscaler. Also, some people wanted to uninstall CA installed by kube-aws and rather use helm or their own manifest for further management.

So for the former case, running eksctl just for updating a single addon would be just cumbersome. For the latter case installing CA via an addon seems redundant.

@michaelbeaumont
Copy link
Contributor

The IAM permissions are now available with iamConfig.WithAddonPolicies.AutoScaler. Seems like consensus is that the autoscaler addon itself doesn't need to be part of eksctl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/add-ons help wanted Extra attention is needed kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants