Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of lazy calls in popups #337

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Fix use of lazy calls in popups #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26eb12b
Skip some flaky iwd tests
elParaguayo Apr 25, 2024
cb90ceb
Fix use of lazy calls in popups
elParaguayo Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
2024-04-25: [BREAKING CHANGE] Update to using lazy calls in popups. Needs latest qtile.
2024-04-08: [RELEASE] v0.25.0 release - compatible with qtile 0.25.0
2024-03-10: [FEATURE] Expose widget popup menu commands and allow custom positioning
2024-03-02: [BUGFIX] Fix bug for volume widgets where bar crashes if volume is greater than 100%
Expand Down
2 changes: 1 addition & 1 deletion qtile_extras/popup/toolkit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,7 +937,7 @@ def button_press(self, x, y, button):
cmd = self.mouse_callbacks[name]
if isinstance(cmd, LazyCall):
status, val = self.qtile.server.call(
(cmd.selectors, cmd.name, cmd.args, cmd.kwargs)
(cmd.selectors, cmd.name, cmd.args, cmd.kwargs, False)
)
if status in (interface.ERROR, interface.EXCEPTION):
logger.error("KB command error %s: %s", cmd.name, val)
Expand Down
10 changes: 7 additions & 3 deletions test/widget/test_iwd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,8 @@ def test_named_interface(iwd_manager):


@config(interface="wlan1")
@pytest.mark.flaky(reruns=5)
# @pytest.mark.flaky(reruns=5)
@pytest.mark.xfail
def test_invalid_interface(iwd_manager, logger):
widget = iwd_manager.c.widget["iwd"]
wait_for_text(widget, "Error")
Expand All @@ -305,22 +306,25 @@ def test_string_format(iwd_manager):


@config(password_entry_app=None)
@pytest.mark.flaky(reruns=5)
# @pytest.mark.flaky(reruns=5)
@pytest.mark.xfail
def test_no_password_entry_app(iwd_manager, logger):
widget = iwd_manager.c.widget["iwd"]
wait_for_text(widget, "qtile_extras (50%)")
assert "No password entry app provided. Agent will not be started." in logger.text


@config(password_entry_app="qtileextraapp")
@pytest.mark.flaky(reruns=5)
# @pytest.mark.flaky(reruns=5)
@pytest.mark.xfail
def test_invalid_password_entry_app(iwd_manager, logger):
widget = iwd_manager.c.widget["iwd"]
wait_for_text(widget, "qtile_extras (50%)")
assert "Cannot find password entry app. Agent will not be started." in logger.text


@config(password_entry_args="This should be a list")
@pytest.mark.xfail
def test_bad_password_entry_args(iwd_manager, logger):
widget = iwd_manager.c.widget["iwd"]
wait_for_text(widget, "qtile_extras (50%)")
Expand Down
Loading