Add test case for wrong normals and uvs after boolean subtraction #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, making a GLB in this case is probably more trouble than it's worth. However, upon debugging your test, I found that roughly half of your normals for A are inverted. Can you fix that and update the test? I'm also curious if that will solve the problem anyway. |
|
Thanks for looking into this. The normals should be fixed now and the test is still failing. |
Merged
|
closed in favor of #587. Thanks again for the test case! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #579.
I know the test case is quite large, but I don't observe the problem for simpler geometry, at least for now.
The
RelatedGLassertion fails here. I hope I used it correctly.