Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cm nav #14

Closed
wants to merge 1 commit into from
Closed

Fix cm nav #14

wants to merge 1 commit into from

Conversation

noCharger
Copy link
Collaborator

Issues

  1. After credential created, would like to return back to the credential listing page
  2. After delete button clicked, would like to refresh the credential table

Attempts

  1. Replace async call to Promise.resolve() on button.onClick (X)
  2. Use props.history.push('') to refresh (x)
  3. Use props.history.push('/') to return back (x)
  4. Add onChange function to refresh the EuiInMemoryTable component (X)
  5. Remove the credential items and set state (X) - the state will not changed unless page refresh
  6. hapy redirected() method (x)

Comments

  1. Attempt 1,2,3 were used in current index pattern management and saved object management.
  2. From debugging, the page refreshed after credential created

@noCharger noCharger requested a review from seraphjiang July 13, 2022 23:54
// TODO: Refactor it by registering client wrapper factory
await http
Promise.resolve(http

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use async await syntax when possible to keep the code more consistent in the repo

@noCharger noCharger mentioned this pull request Jul 19, 2022
@noCharger noCharger closed this Jul 20, 2022
@noCharger noCharger deleted the patch-fix-cm-nav branch July 20, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants