Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

require admin role to use update-alternatives #447

Merged
merged 2 commits into from
May 16, 2018

Conversation

chaintng
Copy link
Contributor

promote update-alternatives command to run as admin role

I have problem when i tried to run this ansible script to Google Compute Engine
It show below error

TASK [elasticsearch : correct java version selected] *****************************************************************************
fatal: [35.186.157.183]: FAILED! => {"changed": false, "failed": true, "msg": "Specified path  does not exist"}
        to retry, use: --limit @/.../Projects/ansible-elasticsearch/site.retry

After debug, it's because java_full_path has empty value because update-alternatives got error but hidden by failed_when: False

It look like, update-alternatives need to run by admin role

promote `update-alternatives` command to run as admin role
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Crazybus
Copy link
Contributor

jenkins test this please

@Crazybus
Copy link
Contributor

The single test failure is from a flaky test.

image

@chaintng Thanks for the fix here!

@Crazybus Crazybus merged commit 46d51ad into elastic:master May 16, 2018
@chaintng
Copy link
Contributor Author

Woohooo, my PR got merged. Thank you!

@Crazybus
Copy link
Contributor

@chaintng yay! I also created a PR to fix the flaky test: #450

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants