This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
[xpack] use elasticsearch default xpack features #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stop forcing es_xpack_features variable in order to let elasticsearch install default features described in http://localhost:9200/_xpack
jmlrt
commented
May 10, 2019
Closed
…sticsearch into default-xpack-features
Crazybus
previously approved these changes
May 28, 2019
We should use default value by default which will be same default value as xpack features. these values can still be forced in `es_config`. The only one we should keep is `xpack.security.enabled`which should be forced to true if a username and password are configured
- xpack scenario will test xpack install with default features - xpack upgrade scenario will fully test security feature - oss-to-xpack-upgrade will test installing only other specific features
All these tests are already in `shared_spec` test
Crazybus
previously approved these changes
May 29, 2019
| @@ -20,4 +21,4 @@ | |||
| - name: Set elasticsearch.keystore Permissions | |||
| become: yes | |||
| file: state=file path={{ conf_dir }}/elasticsearch.keystore owner={{ es_user }} group={{ es_group }} | |||
| when: es_enable_xpack and es_xpack_features is defined and "security" in es_xpack_features and (es_version is version_compare('6.0.0', '>')) | |||
| when: es_enable_xpack | |||
There was a problem hiding this comment.
I think we always want to do this even when using the oss version. But it was apparently already like this so its out of scope. I also think that the package properly creates the keystore with the correct permissions now but would need to confirm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
system_keyfeature (deprecated in 5.6 and removed in 6.0 - Breaking Changes 6.0.0)whenconditions)