Test startup hooks #1167
Merged
Test startup hooks #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errors
Expand to view the steps failures
|
russcam
force-pushed
the
test/startup-hooks
branch
from
43d0195 to
c022ab0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1167 +/- ##
==========================================
+ Coverage 79.44% 79.84% +0.39%
==========================================
Files 160 160
Lines 6543 6543
==========================================
+ Hits 5198 5224 +26
+ Misses 1345 1319 -26
Continue to review full report at Codecov.
|
Linux stages test startup hooks as part of tests
The Mock APM server may be run with an agent version built from a different commit than the current one, so loosen the agent version assertion to just check for major.minor.patch
Avoid race condition where list is accessed before item has been added
Otherwise Race condition can happen where event is raised before new immutable list is assigned to APM server received data.
russcam
force-pushed
the
test/startup-hooks
branch
from
bd2a848 to
90de93f
Compare
gregkalapos
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests that the APM agent startup hook feature is able to configure and setup the agent for ASP.NET Core 3.0, 3.1 and ASP.NET 5, and send APM data to APM server.
A sample ASP.NET (Core) application is included as a target application for startup hooks. Tests start the application, along with a test APM server, make a request to the application, and assert that APM data is captured by APM server.
Startup hook tests run as part of the Tests stage on Linux. A separate Startup Hooks stage is introduced on Windows for testing.
Closes #1073