Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make published Docker images multi-platform, add linux/arm64 plat #2395

Merged
merged 4 commits into from
Jul 10, 2024
Merged

feat: make published Docker images multi-platform, add linux/arm64 plat #2395

merged 4 commits into from
Jul 10, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Jul 10, 2024 •
edited
Loading

Similar to elastic/apm-agent-nodejs#4038

Support for docker images with a multiplatform when a release tag or main.

Test

I used this PR to test the changes for teh release-main:

$ docker inspect docker.elastic.co/observability/apm-agent-dotnet:1.28.1-canary.0.4 | grep -i 'arch'
        "Architecture": "arm64",

Follow-ups

Tag latest is not working

@v1v v1v requested review from Mpdreamz and a team July 10, 2024 07:40
@v1v v1v mentioned this pull request Jul 10, 2024
Merged
Mpdreamz
Mpdreamz approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@v1v v1v merged commit a540168 into main Jul 10, 2024
15 checks passed
@v1v v1v deleted the feature/support-multiplatform branch October 3, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reakaleek reakaleek reakaleek approved these changes

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1v @Mpdreamz @reakaleek