Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs/public-api.asciidoc #332

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Update docs/public-api.asciidoc #332

merged 2 commits into from
Jul 3, 2019

Conversation

gregkalapos
Copy link
Contributor

@gregkalapos gregkalapos commented Jul 1, 2019

Following up on #231 - there was some surprise that Elastic.Apm.Agent.Tracer.CurrentTransaction can be null. We mention this where CurrentTransaction is documented, nevertheless I think a similar note in the CaptureSpan part does not hurt, since we heavily use CurrentTransaction in the code samples.

Plus I promised to add such a note here.

Adding note about potential null in Elastic.Apm.Agent.Tracer.CurrentTransaction
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@SergeyKleyman SergeyKleyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #332 into master will increase coverage by 2.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   75.55%   78.09%   +2.53%     
==========================================
  Files          84       72      -12     
  Lines        2974     2465     -509     
  Branches      580      439     -141     
==========================================
- Hits         2247     1925     -322     
+ Misses        557      361     -196     
- Partials      170      179       +9
Impacted Files Coverage Δ
src/Elastic.Apm/Model/Error.cs 66.66% <0%> (-18.52%) ⬇️
src/Elastic.Apm/Metrics/MetricsCollector.cs 77.27% <0%> (-9.65%) ⬇️
src/Elastic.Apm/Report/PayloadSenderV2.cs 67.64% <0%> (-6.81%) ⬇️
...c/Elastic.Apm.AspNetCore/ApmMiddlewareExtension.cs 45.16% <0%> (-5.91%) ⬇️
src/Elastic.Apm/Model/Span.cs 95.95% <0%> (-4.05%) ⬇️
src/Elastic.Apm/Helpers/SystemInfoHelper.cs 77.04% <0%> (-1.64%) ⬇️
src/Elastic.Apm/Model/Transaction.cs 97.32% <0%> (-0.53%) ⬇️
....Apm/Report/Serialization/PayloadItemSerializer.cs 100% <0%> (ø) ⬆️
src/Elastic.Apm/Helpers/ObjectExtensions.cs 100% <0%> (ø) ⬆️
...pm.Elasticsearch/SerializerDiagnosticsListener .cs
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f58271c...79badf3. Read the comment docs.

@gregkalapos gregkalapos merged commit 76d9647 into elastic:master Jul 3, 2019
@gregkalapos gregkalapos deleted the Docs_CurrentTransactionNullNote branch July 3, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants