Public cleanup #78
Merged
Public cleanup #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This project is referenced in Elastic.Apm.AspNetCore.Tests (which is also signed). To avoid building with warnings the sample project will be also signed.
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 81.6% 82.13% +0.52%
==========================================
Files 35 35
Lines 957 957
Branches 126 125 -1
==========================================
+ Hits 781 786 +5
+ Misses 127 122 -5
Partials 49 49
Continue to review full report at Codecov.
|
Mpdreamz
approved these changes
Jan 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this change is to make sure that the agent initially only has a minimal public API surface. Therefore lots of public things became internal. The intention is to avoid braking changes later. #77
IDiagnosticListenerand all its implementors became internal.IDiagnosticsSubscriberand its implementors remain public. This way from the user's perspective it's easier to know how to subscribe: just use the subscribers, and don't care about the listeners, that's handled internally.Lots of classes from
Elastic.Apm.Model.Payloadbecame internal.Introduced
IErrorinterface, mainly because theErrorclass leaked lots of internal information that is not relevant to users.Removed a couple of properties from
ITransactionandISpan, which could potentially cause problems when users set data that is not accepted by the server. Those properties are available onTransactionandSpan.Due to the previous point I added
internal Span StartSpanInternaltoTransactionandinternal Transaction StartTransactionInternaltoTracer. These can be used in agent dlls to access properties that are not on the public interface.Plus added code signing to
SampleAspNetCoreApp.csprojto avoid build warnings. (It is referenced from a test project, which is signed, so it also should be signed, which it is from now on).