Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding configurable method-name blacklist for trace_methods #476

Merged

Conversation

eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Feb 4, 2019

No description provided.

@eyalkoren eyalkoren requested a review from felixbarny February 4, 2019 15:28
@eyalkoren
Copy link
Contributor Author

Contains the first black list entry to solve #474

@codecov-io
Copy link

Codecov Report

Merging #476 into master will increase coverage by 4.14%.
The diff coverage is 94.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #476      +/-   ##
============================================
+ Coverage     64.46%   68.61%   +4.14%     
- Complexity       68     1386    +1318     
============================================
  Files           164      155       -9     
  Lines          6214     5719     -495     
  Branches        713      608     -105     
============================================
- Hits           4006     3924      -82     
+ Misses         1962     1552     -410     
+ Partials        246      243       -3
Impacted Files Coverage Δ Complexity Δ
...tic/apm/agent/configuration/CoreConfiguration.java 95.83% <100%> (+0.23%) 17 <2> (+17) ⬆️
...java/co/elastic/apm/agent/bci/ElasticApmAgent.java 74.67% <100%> (ø) 22 <1> (+22) ⬆️
...bci/methodmatching/TraceMethodInstrumentation.java 61.7% <75%> (-5.49%) 10 <0> (+10)
.../apm/agent/impl/ContextInScopeRunnableWrapper.java 0% <0%> (-69.24%) 0% <0%> (ø)
...tic/apm/agent/impl/SpanInScopeRunnableWrapper.java 0% <0%> (-64.29%) 0% <0%> (ø)
...va/co/elastic/apm/agent/impl/ElasticApmTracer.java 72.02% <0%> (-7.17%) 39% <0%> (+39%)
...apm/agent/impl/transaction/TraceContextHolder.java 52.63% <0%> (-2.64%) 9% <0%> (+9%)
...astic/apm/agent/impl/transaction/AbstractSpan.java 86.04% <0%> (-2.33%) 17% <0%> (+17%)
...tracing/impl/OpenTracingBridgeInstrumentation.java
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b273d7...06e5f7c. Read the comment docs.

@eyalkoren eyalkoren self-assigned this Feb 4, 2019
@eyalkoren eyalkoren merged commit edb5f87 into elastic:master Feb 4, 2019
@eyalkoren eyalkoren deleted the trace-methods-add-method-name-blacklist branch February 5, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants