Skip to content

Commit

Permalink
drop exporting OTel Metric 'unit'; not in spec, not sure how the valu…
Browse files Browse the repository at this point in the history
…e would be used anyway
  • Loading branch information
trentm committed Apr 4, 2023
1 parent fab0bad commit 94e141d
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions lib/opentelemetry-metrics/ElasticApmMetricExporter.js
Original file line number Diff line number Diff line change
Expand Up @@ -199,10 +199,6 @@ class ElasticApmMetricExporter {
metricsetFromAttrHash[attrHash] = metricset
}
const sample = {}
// XXX drop unit? Java doesn't include it. Not in spec.
if (metricData.descriptor.unit) {
sample.unit = metricData.descriptor.unit
}
switch (metricData.dataPointType) {
case DataPointType.GAUGE:
sample.type = 'gauge'
Expand Down

0 comments on commit 94e141d

Please sign in to comment.