Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ioredis test hangs with [email protected] #1838

Closed
trentm opened this issue Oct 26, 2020 · 0 comments · Fixed by #1839
Closed

ioredis test hangs with [email protected] #1838

trentm opened this issue Oct 26, 2020 · 0 comments · Fixed by #1839
Assignees
Labels

Comments

@trentm
Copy link
Member

trentm commented Oct 26, 2020

$ node --unhandled-rejections=strict test/instrumentation/modules/ioredis.js
TAP version 13
# not nested
ok 1 null
ok 2 should be strictly equal
...
ok 85 should be strictly equal
ok 86 should be truthy
ok 87 should be strictly equal
ok 88 should be strictly equal
ok 89 should be strictly equal
ok 90 should be truthy
# rejections_handled
ok 91 should be truthy
ok 92 should be falsy
<hangs here>

See redis/ioredis#1215
[email protected] included a bug such that a setInterval is uncleared when ending a session via redis.quit().

$ npm ls ioredis
[email protected] /Users/trentm/el/apm-agent-nodejs
└── [email protected]

Earlier ioredis versions do not hit this issue.
Using redis.disconnect() works around the issue.

@trentm trentm self-assigned this Oct 26, 2020
trentm added a commit that referenced this issue Oct 26, 2020
[email protected] includes a bug when using `redis.quit()` that can leave
a setInterval uncleared. See redis/ioredis#1215.

Fixes #1838
trentm added a commit that referenced this issue Oct 26, 2020
[email protected] includes a bug when using `redis.quit()` that can leave
a setInterval uncleared. See redis/ioredis#1215.

Fixes #1838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants