Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] test: fix APM Server cert test to work with 13.9.0+ (c3c119b1) | test: add missing APM Server API Scheme file cloud.json (#1738) #1740

Merged
merged 2 commits into from
May 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions test/integration/allow-invalid-cert.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,8 @@ getPort().then(function (port) {
server.listen(port, function () {
agent.captureError(new Error('boom!'), function () {
t.pass('agent.captureError callback called')

// The async execution order is different in Node.js 8 and below, so in
// other to ensure that server request event fires in older versions of
// Node before we end the test, we wrap this in a setImmediate
setImmediate(function () {
t.end()
server.close()
agent.destroy()
})
server.close()
agent.destroy()
})
})
})
Expand Down
1 change: 1 addition & 0 deletions test/integration/api-schema/download-json-schemas.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ FILES=( \
"spans/span.json" \
"transactions/mark.json" \
"transactions/transaction.json" \
"cloud.json" \
"context.json" \
"http_response.json" \
"message.json" \
Expand Down