Code

feat: Reporter for OTel Metrics#3152

Code

Merged

trentm merged 58 commits intomainelastic/apm-agent-nodejs:mainfrom trentm/otel-metrics-pocelastic/apm-agent-nodejs:trentm/otel-metrics-pocCopy head branch name to clipboardApr 28, 2023

+2,055-99

Commits

Commits on Nov 22, 2022

• feat: a proof-of-concept providing an OTel global meter provider using the OTel SDK

  Show description for 289722f
  trentm

  committed
  289722f

  Copy full SHA for 289722f

Commits on Feb 6, 2023

• first otel metrics provider impl (I've only sanity checked Counter usage); disable the 'OTel Metrics PoC' provider (will clean this out later)

  trentm

  committed
  eb87d72

  Copy full SHA for eb87d72

• Merge branch 'main' into trentm/otel-metrics-poc

  trentm

  committed
  5af565d

  Copy full SHA for 5af565d

Commits on Feb 7, 2023

• cleaning up use case names

  trentm

  committed
  3f5fbf0

  Copy full SHA for 3f5fbf0

• drop the PoC dirs of work

  trentm

  committed
  10c9784

  Copy full SHA for 10c9784

• initial test case for otel metrics (just the API usage use case, and just a Counter so far)

  trentm

  committed
  df7b887

  Copy full SHA for df7b887

• testing tweaks, don't start metrics or register the OTel MeterProvider if metrics is not enabled (metricsInterval=0s)

  trentm

  committed
  e8fe3d0

  Copy full SHA for e8fe3d0

Commits on Feb 8, 2023

• rejigger to no longer use otel.metrics.setGlobalMeterProvider()

  Show description for ba8bc52
  trentm

  committed
  ba8bc52

  Copy full SHA for ba8bc52

• dump stdout/stderr if this test fails (e.g. on Windows in CI) to try to help debug it

  trentm

  committed
  f7dcd8b

  Copy full SHA for f7dcd8b

• fix 'make check'

  trentm

  committed
  2152d14

  Copy full SHA for 2152d14

Commits on Feb 9, 2023

• flail debug output to try to grok Windows test failure in Jenkins CI

  trentm

  committed
  16db977

  Copy full SHA for 16db977

• test: skip an expectation from exit value of subprocess we are SIGTERM'ing

  trentm

  committed
  cf749b0

  Copy full SHA for cf749b0

• get both use cases from the spec working: instrumenting otel/api or otel/sdk-metrics creation of a MetricProvider as needed

  trentm

  committed
  e3f2edd

  Copy full SHA for e3f2edd

• fix 'make check'

  trentm

  committed
  73aaa4e

  Copy full SHA for 73aaa4e

Commits on Feb 10, 2023

• lots of improvements to the examples

  trentm

  committed
  3ad752a

  Copy full SHA for 3ad752a

• test: use undici.request because .fetch is only in Node 16.8+

  trentm

  committed
  6df92f9

  Copy full SHA for 6df92f9

• oh 'make check', I sacrifice these lines for thee

  trentm

  committed
  f4ba0bb

  Copy full SHA for f4ba0bb

• use Delta (for some instrument types) aggregation temporality per our draft spec

  Show description for 5955d74
  trentm

  committed
  5955d74

  Copy full SHA for 5955d74

• test for aggregation temporality for 'counter'

  trentm

  committed
  0d98be9

  Copy full SHA for 0d98be9

Commits on Mar 7, 2023

• add observable counter meter type

  trentm

  committed
  0a70604

  Copy full SHA for 0a70604

• Merge branch 'main' into trentm/otel-metrics-poc

  trentm

  committed
  ba79d6a

  Copy full SHA for ba79d6a

• use the 'Async ...' instrument naming, as used in the lang-generic OTel API docs

  trentm

  committed
  5a32ed0

  Copy full SHA for 5a32ed0

• restore code commented out for dev, fixes 'make check'

  trentm

  committed
  6025c8c

  Copy full SHA for 6025c8c

Commits on Mar 8, 2023

• add Async Gauge metric type

  trentm

  committed
  8d5d9f0

  Copy full SHA for 8d5d9f0

• updowncounter metric type

  trentm

  committed
  4edabbb

  Copy full SHA for 4edabbb

• turn off dev/debugging ignoring metrics, they are needed for activation-method tests

  trentm

  committed
  07894bb

  Copy full SHA for 07894bb

Commits on Mar 9, 2023

• observable UpDownCounter support (modulo possible otel js metrics sdk issue with two readers and an async instrument)

  trentm

  committed
  015c263

  Copy full SHA for 015c263

Commits on Mar 10, 2023

• histograms

  trentm

  committed
  39a4d25

  Copy full SHA for 39a4d25

Commits on Mar 11, 2023

• test handling of attr-sets for separate metricsets

  trentm

  committed
  1a1cac2

  Copy full SHA for 1a1cac2

Commits on Mar 28, 2023

• labels: drop array-valued attrs and warn; cleaning out XXXs

  trentm

  committed
  1d60bc5

  Copy full SHA for 1d60bc5

Commits on Mar 29, 2023

• agent.flush() on forceFlush or shutdown

  trentm

  committed
  cd29e56

  Copy full SHA for cd29e56

• an example using the OTel NodeSDK for metrics setup and shutdown

  trentm

  committed
  80e082c

  Copy full SHA for 80e082c

Commits on Apr 3, 2023

• Merge branch 'main' into trentm/otel-metrics-poc

  trentm

  committed
  2651fe0

  Copy full SHA for 2651fe0

• fix lint; bump to latest otel deps

  trentm

  committed
  05a2320

  Copy full SHA for 05a2320

Commits on Apr 4, 2023

• sdk-metrics ver guard (v1.11.0); separate metricsets per instrumentation scope

  Show description for a4b09be
  trentm

  committed
  a4b09be

  Copy full SHA for a4b09be

• forgot to include this file in previous commit

  trentm

  committed
  3cb2700

  Copy full SHA for 3cb2700

• add the disableMetrics config var and impl it for OTel Metrics and the current metrics system

  trentm

  committed
  b28b182

  Copy full SHA for b28b182

• fix lint

  trentm

  committed
  ecf5ea6

  Copy full SHA for ecf5ea6

• test: update mock to have required new method for 'disableMetrics' work

  trentm

  committed
  8a5ebb5

  Copy full SHA for 8a5ebb5

• quick play with Exponential Histograms; warn when we drop a metric of a type we cannot export

  trentm

  committed
  fab0bad

  Copy full SHA for fab0bad

• drop exporting OTel Metric 'unit'; not in spec, not sure how the value would be used anyway

  trentm

  committed
  94e141d

  Copy full SHA for 94e141d

Commits on Apr 7, 2023

• otel metrics docs

  trentm

  committed
  6eb79f7

  Copy full SHA for 6eb79f7

Commits on Apr 13, 2023

• some tweaks on the docs

  trentm

  committed
  fcd7ffb

  Copy full SHA for fcd7ffb

• doc updates; document customMetricsHistogramBoundaries config var

  trentm

  committed
  9c8d6a9

  Copy full SHA for 9c8d6a9

Commits on Apr 16, 2023

• test: add and improve TAV testing of @opentelemetry/api and sdk-metrics

  Show description for 9337153
  trentm

  committed
  9337153

  Copy full SHA for 9337153

Commits on Apr 17, 2023

• Merge branch 'main' into trentm/otel-metrics-poc

  trentm

  committed
  4e6055d

  Copy full SHA for 4e6055d

• update to latest sdk-metrics (v1.12.0); fix 'npm run test:deps' for runs after some of the nested package.json files have been 'npm install'd

  trentm

  committed
  56a82c3

  Copy full SHA for 56a82c3

• fix tests (need lazy 'npm install' now with separate package); add dependabot for separate packages

  trentm

  committed
  9d16af2

  Copy full SHA for 9d16af2

• clean up otel metrics examples area

  trentm

  committed
  74c5563

  Copy full SHA for 74c5563

• drop the XXX

  trentm

  committed
  1cfc4d5

  Copy full SHA for 1cfc4d5

• flail debugging CI windows failure

  trentm

  committed
  1d501d0

  Copy full SHA for 1d501d0

• Revert "flail debugging CI windows failure"

  Show description for ffd8828
  trentm

  committed
  ffd8828

  Copy full SHA for ffd8828

• another flail to attempt to avoid spurious test failures on windows

  trentm

  committed
  e630cc5

  Copy full SHA for e630cc5

Commits on Apr 27, 2023

• drop unneeded config object guard (from review feedback)

  trentm

  committed
  3feae2b

  Copy full SHA for 3feae2b

• cleaning up final todos now that the spec is merged

  trentm

  committed
  0062d04

  Copy full SHA for 0062d04

Commits on Apr 28, 2023

• doc, comment, log message improvements/corrections with final review

  trentm

  committed
  a474d69

  Copy full SHA for a474d69

• Merge branch 'main' into trentm/otel-metrics-poc

  trentm

  committed
  751b2e7

  Copy full SHA for 751b2e7

• changelog entry

  trentm

  committed
  1eb8ba1

  Copy full SHA for 1eb8ba1