Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: limit parallel GH Action test runs to try to avoid 429 errors on checkout #3180

Merged
merged 4 commits into from
Mar 1, 2023
Merged

ci: limit parallel GH Action test runs to try to avoid 429 errors on checkout #3180

merged 4 commits into from
Mar 1, 2023

Conversation

trentm
Copy link
Member

@trentm trentm commented Mar 1, 2023

Fixes: #3179

@trentm trentm self-assigned this Mar 1, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Mar 1, 2023
trentm added 2 commits March 1, 2023 14:13
@trentm
flail around this GH Action error:
b624d14 
    The workflow is not valid. .github/workflows/test.yml (Line: 121, Col: 23): Unexpected value '10'
@trentm
correct placement of 'max-parallel' in strategy config
0b5564d
@apmmachine
Copy link
Contributor

apmmachine commented Mar 1, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-03-01T22:30:21.976+0000

  • Duration: 21 min 47 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm
Copy link
Member Author

trentm commented Mar 1, 2023

Currently with "lint" and "test" workflows we have 27 jobs. It would be nice if we only doubled the execution time with max-parallel. Therefore I'll try 15 to start (more than half of 27).

@trentm
Copy link
Member Author

trentm commented Mar 1, 2023

I'm not sure this will actually help. To know we'd ideally get some rate limiting headers from the failing actions/checkout requests. Also we'd want to understand what the rate limits actually are in this case. I'm not sure from https://docs.github.com/en/rest/overview/resources-in-the-rest-api?apiVersion=2022-11-28#rate-limiting which case applies here. Is a workflow in a GitHub Action a "GitHub App"? Etc.

@trentm trentm merged commit 45cb30b into main Mar 1, 2023
@trentm trentm deleted the trentm/ci-workaround-429s branch March 1, 2023 23:56
trentm added a commit that referenced this pull request Mar 6, 2023
@trentm
ci: drop max-parallel for GH actions
2ec0a92 
Earlier in #3180 we added max-parallel:15 as an attempted workaround
errors in the "actions/checkout@v2" (#3179). We also changed to
"actions/checkout@v3" in that change.
actions/checkout#417 suggests that the update
to v3 is sufficient to fix, so let's get the parallelism back.

Refs: #3179
@trentm trentm mentioned this pull request Mar 6, 2023
Merged
trentm added a commit that referenced this pull request Mar 6, 2023
@trentm
ci: drop max-parallel for GH actions (#3191)
486fd03 
Earlier in #3180 we added max-parallel:15 as an attempted workaround
errors in the "actions/checkout@v2" (#3179). We also changed to
"actions/checkout@v3" in that change.
actions/checkout#417 suggests that the update
to v3 is sufficient to fix, so let's get the parallelism back.

Refs: #3179
v1v added a commit to v1v/apm-agent-nodejs that referenced this pull request Mar 21, 2023
@v1v
Merge remote-tracking branch 'upstream/main' into feature/action-tav
2fa46dc 
* upstream/main: (44 commits)
  action: abort builds when new commit (elastic#3196)
  docs: note that 3.40.0 was bad release (elastic#3194)
  chore(deps-dev): bump @babel/cli from 7.20.7 to 7.21.0 (elastic#3170)
  chore(deps-dev): bump @babel/core from 7.20.2 to 7.21.0 (elastic#3169)
  ci: drop max-parallel for GH actions (elastic#3191)
  test: correct sense of test message (elastic#3186)
  3.43.0 (elastic#3184)
  test, ci: some small changes (elastic#3183)
  ci: limit parallel GH Action test runs to try to avoid 429 errors on checkout (elastic#3180)
  fix: transaction name for Next.js API routes in [email protected] was broken (elastic#3178)
  mongodb@5 support (elastic#3177)
  chore(deps-dev): bump body-parser from 1.20.1 to 1.20.2 (elastic#3171)
  chore(deps-dev): bump restify from 11.0.0 to 11.1.0 (elastic#3172)
  docs: minor fix in README for Azure Functions example (elastic#3175)
  feat: Make Agent.flush() return a Promise if no callback is passed as param (elastic#3167)
  chore(deps-dev): bump @types/node from 18.11.9 to 18.14.0 (elastic#3165)
  chore(deps-dev): bump @hapi/hapi from 21.2.1 to 21.3.0 (elastic#3166)
  chore(deps-dev): bump undici from 5.19.1 to 5.20.0 (elastic#3164)
  chore(deps-dev): bump fastify from 4.12.0 to 4.13.0 (elastic#3154)
  Use composite action for updatecli workflow (elastic#3162)
  ...
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
@trentm @PeterEinberger
ci: limit parallel GH Action test runs to try to avoid 429 errors on …
603ba54 
…checkout (elastic#3180)

Fixes: elastic#3179
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
@trentm @PeterEinberger
ci: drop max-parallel for GH actions (elastic#3191)
60afd08 
Earlier in elastic#3180 we added max-parallel:15 as an attempted workaround
errors in the "actions/checkout@v2" (elastic#3179). We also changed to
"actions/checkout@v3" in that change.
actions/checkout#417 suggests that the update
to v3 is sufficient to fix, so let's get the parallelism back.

Refs: elastic#3179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@trentm trentm

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: getting occasional 429 errors in GH Actions
2 participants
@trentm @apmmachine