Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php 8.4 compatibility #1255

Merged
merged 36 commits into from
Jan 16, 2025
Merged

Add php 8.4 compatibility #1255

merged 36 commits into from
Jan 16, 2025

Conversation

julien-maurel
Copy link
Contributor

@julien-maurel julien-maurel commented Dec 30, 2024

Hi
I'm not sure everything is ok, i did it for my needed so I just know that .deb file works
But if these changes can help...

Copy link

cla-checker-service bot commented Dec 30, 2024

💚 CLA has been signed

@intuibase intuibase self-requested a review January 9, 2025 15:37
@intuibase
Copy link
Contributor

Hey @julien-maurel
Thank you for your contribution.
I've updated yours branch a bit to pass static and phpt tests. I hope you don’t mind that I pushed some changes to your repository.

@julien-maurel
Copy link
Contributor Author

Hey @julien-maurel Thank you for your contribution. I've updated yours branch a bit to pass static and phpt tests. I hope you don’t mind that I pushed some changes to your repository.

You're welcome, I would have liked to finish it, but difficult to take time to check how CI and other formats work.
No worries, commit as you like, I fork it just do do the PR :)

@intuibase intuibase self-assigned this Jan 13, 2025
@intuibase
Copy link
Contributor

Hey @julien-maurel

We're ready to merge your contribution, please sign contributor agreement mentioned here #1255 (comment)

@julien-maurel
Copy link
Contributor Author

Hi @intuibase ,
I think I've already did it when I opened the PR, but I did it again, is it ok ?

@SergeyKleyman
Copy link
Contributor

run elasticsearch-ci/docs

@intuibase
Copy link
Contributor

run docs-build

@intuibase intuibase merged commit 032adca into elastic:main Jan 16, 2025
232 checks passed
@intuibase
Copy link
Contributor

@julien-maurel thank you again for yours contribution, it will be included in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants