Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for boolean and number values for labels #272

Closed
1 task done
hmdhk opened this issue May 27, 2019 · 2 comments
Closed
1 task done

Add support for boolean and number values for labels #272

hmdhk opened this issue May 27, 2019 · 2 comments
Assignees
Milestone

Comments

@hmdhk
Copy link
Contributor

hmdhk commented May 27, 2019

Currently, boolean and number values for labels are converted to their string representation before being added to the payload. However, with APM Server 6.7, the support for these value types has been added to APM Server. We should start sending the raw values for these types.

Please note that this is a breaking change for older versions of APM server (prior to 6.7) and we should update the documentation to reflect this.

  • We should add new tests for these
@felixbarny
Copy link
Member

One way to get around making this a breaking change is to check the APM Server version and convert numbers and booleans to strings when connected to an APM Server < 6.7.
I guess it depends on how urgent the need to offer these APIs are for the RUM agent and if it's worth the complexity. Especially for the RUM agent that would, however, mean another request to the APM Server just to check the version. That makes it less feasible for the RUM agent. Still wanted to mention it because it may be relevant for other agents.

@hmdhk
Copy link
Contributor Author

hmdhk commented May 28, 2019

Thanks @felixbarny , I think the cost of making an extra request just to check the APM server version, is too high. I don't see the breaking change as a big issue as long as we release it in a major version.

Plus, we can make documentation about how users can convert those values to string before calling the agent APIs, if the support for older versions is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants