Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rum): deprecate addTags in favor of addLabels #270

Merged
merged 3 commits into from
Jun 4, 2019

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented May 23, 2019

@vigneshshanmugam vigneshshanmugam requested review from hmdhk and bmorelli25 and removed request for hmdhk May 23, 2019 17:28
@vigneshshanmugam vigneshshanmugam self-assigned this May 23, 2019
docs/agent-api.asciidoc Outdated Show resolved Hide resolved
@vigneshshanmugam vigneshshanmugam requested a review from hmdhk May 28, 2019 14:42
@hmdhk hmdhk merged commit 3e313d3 into elastic:master Jun 4, 2019
@vigneshshanmugam vigneshshanmugam deleted the deprecate-tags branch June 5, 2019 12:44
@eliaskardel
Copy link

image

I am running the latest version of all components elastic search, Kibana, APM Server, RUM JS agent.

The addLabel() function doesnt give me anything on the other side. I switched on debug in the agent and saw my labels in the developer console. However they seem to not end up in eleastic search.

@eliaskardel
Copy link

            const transaction = apm.startTransaction('transaction1', 'custom')
            const httpSpan = transaction.startSpan('span2', 'custom')
            httpSpan.addLabels({'test_label' : 'test_label'})
            httpSpan.end()
            transaction.end()

David-Development pushed a commit to David-Development/apm-agent-rum-js that referenced this pull request Oct 20, 2021
* feat(rum): deprecate addTags in favor of addLabels

* add review comments and fix lint

* depreacte tags on span-base
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants