This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
fix: remove params from JJB definition #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
cachedout
approved these changes
Aug 19, 2020
v1v
referenced
this pull request
in v1v/apm-pipeline-library-backup
Sep 3, 2020
* upstream/master: (21 commits) fix: remove params from JJB definition (#701) chore: convert regular pipeline for APM to mbp (#699) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.134 [CI] git commit with correct user.email (#700) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.133 fix read only env variable (#698) chore: include schedule in JJBB for APM specs sync (#696) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.132 Fix opbeans-frontend release process (#697) Use real email account (#695) chore: add force parameter to the JJBB job for APM specs sync (#693) docs: update CHANGELOG.md [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.1.131 ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We discovered that adding params in the JJB definition caused an error when creating the job in the Jenkins instance.
Although the JJBB is valid (checked with
./local/test-jjbb.sh -j .ci/jobs/apm-update-specs-mbp.yml), the job is not created, throwing the same error as in the INFRA build: https://infra-ci.elastic.co/job/elastic+apm-pipeline-library+master+jjbb+no-trigger/10/consoleAs a side effect, we modified the script to reuse the image used to validate the JJB file.
Why is it important?
The migration of fthe APM pipeline from regular to MBP was blockedd by this issue.