Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit docker packaging tests #1693

Closed
graphaelli opened this issue Dec 19, 2018 · 3 comments
Closed

audit docker packaging tests #1693

graphaelli opened this issue Dec 19, 2018 · 3 comments
Assignees

Comments

@graphaelli
Copy link
Member

graphaelli commented Dec 19, 2018

With the recent move to own docker packaging for apm-server in #1543, ensure that all of the tests covered by apm-server-docker are also covered now - some are already accounted for in the package tests.

@graphaelli
Copy link
Member Author

all of https://github.com/elastic/apm-server-docker/blob/master/tests/test_config.py:

  • test_config_file_passes_config_test - apm-server -configtest exits 0 (should actually be apm-server test config)
  • test_apm_server_listens_on_all_interfaces - apm-server.host == '0.0.0.0:8200'
  • test_elasticsearch_output_points_to_elasticsearch_host - output.elasticsearch.hosts == ['elasticsearch:9200']

from https://github.com/elastic/apm-server-docker/blob/master/tests/test_files.py:

  • test_suid_bit_removed - find / -xdev -perm -4000 returns 0 and no files

all of https://github.com/elastic/apm-server-docker/blob/master/tests/test_labels.py

  • license check in particular

@jalvz
Copy link
Contributor

jalvz commented Aug 26, 2019

@graphaelli where do we are here? needs review?

@graphaelli
Copy link
Member Author

looks like I just forgot to close this, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants