package docker container images with mage #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins, run package tests please |
|
Missed it while reviewing the beats changes, expected: |
|
elastic/beats#9063 up for that |
|
Ready for review again |
|
jenkins, run package tests please |
jsoriano
approved these changes
Nov 13, 2018
simitt
approved these changes
Nov 14, 2018
This was referenced Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to elastic/beats#8898, packaging can now produce a docker container image.
Note the this adds an
apm-server.docker.ymlrather than generating one on the fly like beats does. I intend to follow up with a change to generate this file instead.