Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.7] fix: correct smoke tests os (backport #10829) #10831

Merged
merged 1 commit into from
May 17, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 17, 2023

This is an automatic backport of pull request #10829 done by Mergify.
Cherry-pick of a86ea9e has failed:

On branch mergify/bp/8.7/pr-10829
Your branch is up to date with 'origin/8.7'.

You are currently cherry-picking commit a86ea9ea.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   testing/smoke/test_supported_os.sh

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Signed-off-by: Adrien Mannocci <[email protected]>
(cherry picked from commit a86ea9e)

# Conflicts:
#	testing/smoke/test_supported_os.sh
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels May 17, 2023
@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-17T13:21:07.872+0000

  • Duration: 12 min 35 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

📚 Go benchmark report

Diff with the 8.7 branch

goos: linux
goarch: amd64
pkg: github.com/elastic/apm-server/internal/agentcfg
cpu: 12th Gen Intel(R) Core(TM) i5-12500
                                  │ build/8.7/bench.out │             bench.out              │
                                  │       sec/op        │    sec/op     vs base              │
geomean                                    69.69n         69.50n        -0.27%
¹ need >= 6 samples for confidence interval at level 0.95

                                  │ build/8.7/bench.out │              bench.out              │
                                  │        B/op         │    B/op      vs base                │
geomean                                               ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                                  │ build/8.7/bench.out │              bench.out              │
                                  │      allocs/op      │  allocs/op   vs base                │
geomean                                               ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

pkg: github.com/elastic/apm-server/internal/beater/request
                                             │ build/8.7/bench.out │             bench.out              │
                                             │       sec/op        │    sec/op     vs base              │
geomean                                               906.0n         875.5n        -3.37%
¹ need >= 6 samples for confidence interval at level 0.95

                                             │ build/8.7/bench.out │               bench.out               │
                                             │        B/op         │     B/op       vs base                │
geomean                                                          ³                  +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                                             │ build/8.7/bench.out │              bench.out              │
                                             │      allocs/op      │  allocs/op   vs base                │
geomean                                                          ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

pkg: github.com/elastic/apm-server/internal/publish
             │ build/8.7/bench.out │          bench.out           │
             │       sec/op        │   sec/op     vs base         │
¹ need >= 6 samples for confidence interval at level 0.95

             │ build/8.7/bench.out │           bench.out            │
             │        B/op         │     B/op       vs base         │
¹ need >= 6 samples for confidence interval at level 0.95

             │ build/8.7/bench.out │           bench.out           │
             │      allocs/op      │  allocs/op    vs base         │
¹ need >= 6 samples for confidence interval at level 0.95

pkg: github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics
                 │ build/8.7/bench.out │           bench.out           │
                 │       sec/op        │    sec/op     vs base         │
¹ need >= 6 samples for confidence interval at level 0.95

                 │ build/8.7/bench.out │            bench.out             │
                 │        B/op         │     B/op       vs base           │
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

                 │ build/8.7/bench.out │           bench.out            │
                 │      allocs/op      │  allocs/op   vs base           │
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

pkg: github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics
                        │ build/8.7/bench.out │           bench.out           │
                        │       sec/op        │    sec/op     vs base         │
¹ need >= 6 samples for confidence interval at level 0.95

                        │ build/8.7/bench.out │           bench.out            │
                        │        B/op         │    B/op      vs base           │
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

                        │ build/8.7/bench.out │           bench.out            │
                        │      allocs/op      │  allocs/op   vs base           │
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

pkg: github.com/elastic/apm-server/x-pack/apm-server/sampling
               │ build/8.7/bench.out │             bench.out              │
               │       sec/op        │    sec/op     vs base              │
geomean                 618.6n         596.9n        -3.51%
¹ need >= 6 samples for confidence interval at level 0.95

               │ build/8.7/bench.out │               bench.out               │
               │        B/op         │     B/op       vs base                │
geomean                            ³                  +0.03%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

               │ build/8.7/bench.out │              bench.out              │
               │      allocs/op      │  allocs/op   vs base                │
geomean                            ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

pkg: github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage
                                            │ build/8.7/bench.out │              bench.out              │
                                            │       sec/op        │    sec/op     vs base               │
WriteTransaction/nop_codec_big_tx-12                 715.8n ± ∞ ¹   340.4n ± ∞ ¹  -52.44% (p=0.016 n=5)
geomean                                              32.48µ         31.54µ         -2.88%
¹ need >= 6 samples for confidence interval at level 0.95

                                            │ build/8.7/bench.out │               bench.out                │
                                            │        B/op         │      B/op       vs base                │
geomean                                             31.37Ki          31.40Ki        +0.08%
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

                                            │ build/8.7/bench.out │              bench.out               │
                                            │      allocs/op      │  allocs/op    vs base                │
geomean                                               144.7          144.7        +0.00%
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat

@mergify mergify bot merged commit 0955af8 into 8.7 May 17, 2023
@mergify mergify bot deleted the mergify/bp/8.7/pr-10829 branch May 17, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants